lkml.org 
[lkml]   [2019]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags
    On Fri, Mar 15, 2019 at 10:20:20AM +0100, Christoph Hellwig wrote:
    > On Fri, Mar 15, 2019 at 04:57:36PM +0800, Jianchao Wang wrote:
    > > Hi Jens
    > >
    > > As we know, there is a risk of accesing stale requests when iterate
    > > in-flight requests with tags->rqs[] and this has been talked in following
    > > thread,
    > > [1] https://marc.info/?l=linux-scsi&m=154511693912752&w=2
    > > [2] https://marc.info/?l=linux-block&m=154526189023236&w=2
    >
    > I'd rather take one step back and figure out why we are iterating
    > the busy requests. There really shouldn't be any reason why a driver
    > is even doings that (vs some error handling helpers in the core
    > block code that can properly synchronize).

    I use it in NBD to error out any pending requests for forced disconnects. I'd
    be happy to use some other blessed interface, I'm not married to this one.
    Thanks,

    Josef

    \
     
     \ /
      Last update: 2019-03-15 14:30    [W:3.045 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site