Messages in this thread | | | From | Peng Fan <> | Subject | RE: [PATCH 2/2] ARM: imx: mach-imx7ulp: warn when imx_soc_device_init fail | Date | Fri, 15 Mar 2019 12:58:18 +0000 |
| |
> -----Original Message----- > From: Aisheng Dong > Sent: 2019年3月15日 18:22 > To: Peng Fan <peng.fan@nxp.com>; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > dl-linux-imx <linux-imx@nxp.com>; Anson Huang <anson.huang@nxp.com>; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org > Cc: van.freenix@gmail.com > Subject: RE: [PATCH 2/2] ARM: imx: mach-imx7ulp: warn when > imx_soc_device_init fail > > > From: Peng Fan > > > > [PATCH 2/2] ARM: imx: mach-imx7ulp: warn when imx_soc_device_init fail > > ARM: imx: imx7ulp: ...
Ok. > > > Follow other i.MX6/7 machince code to check return value of > > imx_soc_device_init and warn when fail. > > > > Also drop of_platform_default_populate, because > > "arch_initcall_sync(of_platform_default_populate_init);" could be used > > to populate the device tree. > > > > This could be in separate patch.
I'll do it in v2 after we agree the change in the first patch.
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > arch/arm/mach-imx/mach-imx7ulp.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-imx/mach-imx7ulp.c > > b/arch/arm/mach-imx/mach-imx7ulp.c > > index 11ac71aaf965..6d823f05d9aa 100644 > > --- a/arch/arm/mach-imx/mach-imx7ulp.c > > +++ b/arch/arm/mach-imx/mach-imx7ulp.c > > @@ -53,11 +53,16 @@ static void __init imx7ulp_set_revision(void) > > > > static void __init imx7ulp_init_machine(void) { > > + struct device *soc_dev; > > + > > + soc_dev = imx_soc_device_init(); > > + if (soc_dev == NULL) > > + pr_warn("failed to initialize soc device\n"); > > + > > Should this be under set revision?
Just follow other i.MX6/7 platforms practice, I could move this under set revision in v2 if you prefer.
Thanks, Peng.
> > Regards > Dong Aisheng > > > imx7ulp_pm_init(); > > > > mxc_set_cpu_type(MXC_CPU_IMX7ULP); > > imx7ulp_set_revision(); > > - of_platform_default_populate(NULL, NULL, imx_soc_device_init()); > > } > > > > static const char *const imx7ulp_dt_compat[] __initconst = { > > -- > > 2.16.4
| |