lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH 1/2] cifs: remove unused status severity defines
    updated it to fix the spelling mistake


    On Thu, Mar 14, 2019 at 1:54 AM Steve French <smfrench@gmail.com> wrote:
    >
    > Since this file (smb2status.h) is intended to track the official
    > protocol documentation (albeit smb2status.h probably needs to be
    > updated), in this case the protocol document MS-ERREF. I would prefer
    > to keep it closer to MS-ERREF and leave definitions in even if unused
    > (if nothing else it helps some of us when debugging to recognize what
    > these errors on the wire mean). There is a real danger that we have
    > run into in the past that in removing some protocol definitions
    > (flags, etc.) from the code or forgetting to update our headers to
    > match newer versions of the protocol specifications, that with future
    > code changes we can forget to handle flags (for example) or misparse
    > responses due to not realizing that there are additional flags that
    > need to be parsed.
    >
    > On Thu, Mar 14, 2019 at 1:17 AM Sergey Senozhatsky
    > <sergey.senozhatsky.work@gmail.com> wrote:
    > >
    > > STATUS_SEVERITY_* do not appear to be used by anyone, so
    > > drop them. Besides, the name of __constant_cpu_to_le32()
    > > is misspelled there: __constanst_cpu_to_le32().
    > >
    > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    > > ---
    > > fs/cifs/smb2status.h | 5 -----
    > > 1 file changed, 5 deletions(-)
    > >
    > > diff --git a/fs/cifs/smb2status.h b/fs/cifs/smb2status.h
    > > index 3d5f62150de4..e9da9c6da277 100644
    > > --- a/fs/cifs/smb2status.h
    > > +++ b/fs/cifs/smb2status.h
    > > @@ -29,11 +29,6 @@
    > > * C is set if "customer defined" error, N bit is reserved and MBZ
    > > */
    > >
    > > -#define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)
    > > -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
    > > -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
    > > -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
    > > -
    > > struct ntstatus {
    > > /* Facility is the high 12 bits of the following field */
    > > __le32 Facility; /* low 2 bits Severity, next is Customer, then rsrvd */
    > > --
    > > 2.21.0
    > >
    >
    >
    > --
    > Thanks,
    >
    > Steve



    --
    Thanks,

    Steve
    From c1d061d2d47d536d7674a162937b51d8dd7ac7dc Mon Sep 17 00:00:00 2001
    From: Steve French <stfrench@microsoft.com>
    Date: Thu, 14 Mar 2019 01:56:34 -0500
    Subject: [PATCH] smb2: fix typo in definition of a few error flags

    As Sergey Senozhatsky pointed out __constant_cpu_to_le32()
    is misspelled in a few definitions in the list of status
    codes smb2status.h as __constanst_cpu_to_le32()

    Signed-off-by: Steve French <stfrench@microsoft.com>
    CC: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    ---
    fs/cifs/smb2status.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/fs/cifs/smb2status.h b/fs/cifs/smb2status.h
    index 3d5f62150de4..f5429c8bfb0d 100644
    --- a/fs/cifs/smb2status.h
    +++ b/fs/cifs/smb2status.h
    @@ -30,9 +30,9 @@
    */

    #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)
    -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
    -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
    -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
    +#define STATUS_SEVERITY_INFORMATIONAL cpu_to_le32(0x0001)
    +#define STATUS_SEVERITY_WARNING cpu_to_le32(0x0002)
    +#define STATUS_SEVERITY_ERROR cpu_to_le32(0x0003)

    struct ntstatus {
    /* Facility is the high 12 bits of the following field */
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-03-14 08:05    [W:2.525 / U:0.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site