Messages in this thread | | | Subject | Re: [PATCH] firewire: mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Thu, 14 Mar 2019 13:42:14 -0500 |
| |
On 3/14/19 5:00 AM, Stefan Richter wrote:
[..]
>> diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c >> index 35e784cffc23..7e5c98840b80 100644 >> --- a/drivers/firewire/core-iso.c >> +++ b/drivers/firewire/core-iso.c >> @@ -308,7 +308,7 @@ static int manage_channel(struct fw_card *card, int irm_id, int generation, >> if ((data[0] & bit) == (data[1] & bit)) >> continue; >> >> - /* 1394-1995 IRM, fall through to retry. */ >> + /* fall through - to retry for 1394-1995 IRM */ > > If you don't mind, I will apply your patch with a different wording of this > comment: > > /* fall through - It's an 1394-1995 IRM, retry. */ > > I'll mark my modification to your patch in the signed-off-by-tag. >
Sure. That's fine with me.
Thank you. -- Gustavo
| |