lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user space
>>> On 14.03.19 at 16:40, <david@redhat.com> wrote:
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
> while (pgno < nr_pages) {
> page = balloon_retrieve(true);
> if (page) {
> + __ClearPageOffline(page);
> pages[pgno++] = page;

While this one's fine, ...

> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>
> for (i = 0; i < nr_pages; i++) {
> if (pages[i])
> + __SetPageOffline(pages[i]);
> balloon_append(pages[i]);
> }

... I think you want to add a pair of braces here.

Jan


\
 
 \ /
  Last update: 2019-03-14 16:49    [W:0.185 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site