Messages in this thread | | | Date | Thu, 14 Mar 2019 13:38:11 +0100 | From | Jan Kara <> | Subject | Re: fs/notify/fanotify/fanotify.c:198:2: note: in expansion of macro 'pr_warn_ratelimited' |
| |
On Thu 14-03-19 14:01:18, Amir Goldstein wrote: > On Thu, Mar 14, 2019 at 10:37 AM Jan Kara <jack@suse.cz> wrote: > > > > AFAICS this is the known problem with weird mips definitions of > > __kernel_fsid_t which uses long whereas all other architectures use int, > > right? Seeing that mips can actually have 8-byte longs, I guess this > > bogosity is just wired in the kernel API and we cannot easily fix it in > > mips (mips guys, correct me if I'm wrong). So what if we just > > unconditionally typed printed values to unsigned int to silence the > > warning? > > I don't understand why. To me that sounds like papering over a bug. > > See this reply from mips developer Paul Burton: > https://marc.info/?l=linux-fsdevel&m=154783680019904&w=2 > mips developers have not replied to the question why __kernel_fsid_t > should use long.
Ah, right. I've missed that mips defines __kernel_fsid_t only if sizeof(long) == 4. OK, than fixing MIPS headers is definitely what we ought to do. Mips guys, any reason why the patch from Ralf didn't get merged yet?
Honza
-- Jan Kara <jack@suse.com> SUSE Labs, CR
| |