lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 1/7] iommu: Move iommu_group_create_direct_mappings to after device_attach
    From
    Date
    If an IOMMU driver requires to know which IOMMU a domain is associated
    to initialise a domain then it will do so in device_attach, before which
    it is not safe to call iommu_ops.

    Signed-off-by: James Sewart <jamessewart@arista.com>
    ---
    drivers/iommu/iommu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
    index 3ed4db334341..1c6ffbb2d20e 100644
    --- a/drivers/iommu/iommu.c
    +++ b/drivers/iommu/iommu.c
    @@ -652,8 +652,6 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev)

    dev->iommu_group = group;

    - iommu_group_create_direct_mappings(group, dev);
    -
    mutex_lock(&group->mutex);
    list_add_tail(&device->list, &group->devices);
    if (group->domain)
    @@ -662,6 +660,8 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev)
    if (ret)
    goto err_put_group;

    + iommu_group_create_direct_mappings(group, dev);
    +
    /* Notify any listeners about change to group. */
    blocking_notifier_call_chain(&group->notifier,
    IOMMU_GROUP_NOTIFY_ADD_DEVICE, dev);
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-03-14 12:59    [W:3.521 / U:0.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site