Messages in this thread | | | Subject | Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store | From | Rasmus Villemoes <> | Date | Thu, 14 Mar 2019 10:57:55 +0100 |
| |
On 14/03/2019 10.31, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: >> +static void set_device(struct led_netdev_data *trigger_data, >> + const char *buf, size_t size) > > "set_device" is a very generic name. Can you please prefix it with > "ledtrig_netdev_"?
Sure. Will do next round.
| |