| Date | Thu, 14 Mar 2019 10:31:11 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store |
| |
Hello,
On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: > +static void set_device(struct led_netdev_data *trigger_data, > + const char *buf, size_t size)
"set_device" is a very generic name. Can you please prefix it with "ledtrig_netdev_"?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
|