Messages in this thread | | | Date | Thu, 14 Mar 2019 14:38:38 +0530 | From | Viresh Kumar <> | Subject | Re: [greybus-dev] [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get |
| |
On 14-03-19, 01:45, Kangjie Lu wrote: > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c > index d44b070d8862..c2a4af4c1d06 100644 > --- a/drivers/staging/greybus/audio_manager.c > +++ b/drivers/staging/greybus/audio_manager.c > @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) > int err; > > id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL); > + if (id < 0) > + return id; > + > err = gb_audio_manager_module_create(&module, manager_kset, > id, desc); > if (err) {
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |