lkml.org 
[lkml]   [2019]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] appletalk: Fix potential NULL pointer dereference in unregister_snap_client
From
From: Yue Haibing <yuehaibing@huawei.com>
Date: Tue, 12 Mar 2019 10:04:26 +0800

> timer_setup(&aarp_timer, aarp_expire_timeout, 0);
> aarp_timer.expires = jiffies + sysctl_aarp_expiry_time;
> add_timer(&aarp_timer);
> - register_netdevice_notifier(&aarp_notifier);
> + rc = register_netdevice_notifier(&aarp_notifier);
> + if (rc)
> + unregister_snap_client(aarp_dl);
> + return rc;

You've left the timer running in this error path.

\
 
 \ /
  Last update: 2019-03-13 22:03    [W:0.055 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site