Messages in this thread | | | From | Mathieu Malaterre <> | Date | Wed, 13 Mar 2019 21:52:41 +0100 | Subject | Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs |
| |
On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Conceptually this seems pretty reasonable. Though, style-wise, perhaps > you might want to put those breaks on the next line too, i.e. s/; > break;/;\n\t\tbreak;/?
Good point. This needs some more love since checkpatch complains now with:
ERROR: trailing statements should be on next line #42: FILE: lib/siphash.c:77: + case 4: b |= le32_to_cpup(data);
Let me merge all that and send a v2.
Thanks
| |