Messages in this thread | | | Subject | Re: [PATCH] net: ieee802154: fix a potential NULL pointer dereference | From | Stefan Schmidt <> | Date | Wed, 13 Mar 2019 10:09:34 +0100 |
| |
Hello.
[please ignore the first mail, hit send to early]
On 11.03.19 08:25, Kangjie Lu wrote: > In case alloc_ordered_workqueue fails, the fix releases > sources and returns -ENOMEM to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/net/ieee802154/adf7242.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index cd1d8faccca5..cd6b95e673a5 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1268,6 +1268,10 @@ static int adf7242_probe(struct spi_device *spi) > INIT_DELAYED_WORK(&lp->work, adf7242_rx_cal_work); > lp->wqueue = alloc_ordered_workqueue(dev_name(&spi->dev), > WQ_MEM_RECLAIM); > + if (unlikely(!lp->wqueue)) { > + ret = -ENOMEM; > + goto err_hw_init; > + } > > ret = adf7242_hw_init(lp); > if (ret) >
This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks!
regards Stefan Schmidt
| |