Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/64s: Mark 'dummy_copy_buffer' as used | Date | Wed, 13 Mar 2019 15:05:04 +1100 |
| |
Christophe Leroy <christophe.leroy@c-s.fr> writes: > On 03/12/2019 08:29 PM, Mathieu Malaterre wrote: >> In commit 07d2a628bc00 ("powerpc/64s: Avoid cpabort in context switch >> when possible") a buffer 'dummy_copy_buffer' was introduced. gcc does >> not see this buffer being used in the inline assembly within function >> '__switch_to', explicitly marked this variable as being used. >> >> Prefer using '__aligned' to get passed line over 80 characters warning >> in checkpatch. > > Powerpc accepts 90 characters, use arch/powerpc/tools/checkpatch.sh > >> >> This remove the following warning: >> >> arch/powerpc/kernel/process.c:1156:17: error: 'dummy_copy_buffer' defined but not used [-Werror=unused-const-variable=] > > commit 2bf1071a8d50 ("powerpc/64s: Remove POWER9 DD1 support") has > removed the fonction using 'dummy_copy_buffer' so you should remove it > completely.
Yes that would be better, thanks.
cheers
| |