Messages in this thread | | | Date | Tue, 12 Mar 2019 17:17:05 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint |
| |
On Sat 02-03-19 12:38:57, Yafang Shao wrote: > show the gfp flag names instead of the gfp_mask could make the trace > more convenient.
Agreed
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > include/trace/events/compaction.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h > index 6074eff..e66afb818 100644 > --- a/include/trace/events/compaction.h > +++ b/include/trace/events/compaction.h > @@ -189,9 +189,9 @@ > __entry->prio = prio; > ), > > - TP_printk("order=%d gfp_mask=0x%x priority=%d", > + TP_printk("order=%d gfp_mask=%s priority=%d", > __entry->order, > - __entry->gfp_mask, > + show_gfp_flags(__entry->gfp_mask), > __entry->prio) > ); > > -- > 1.8.3.1 >
-- Michal Hocko SUSE Labs
| |