lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel/trace/trace_kprobe.c - fix comment format
    On Tue, 12 Mar 2019 05:08:30 -0400
    valdis.kletnieks@vt.edu wrote:

    > On Tue, 12 Mar 2019 04:58:32 -0400, "Valdis Klētnieks" said:
    > >
    > > CC kernel/trace/trace_kprobe.o
    > > kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
    > >
    > > The real problem is that a comment looked like kerneldoc when it shouldn't be...
    >
    > After finding another case of this, it's debatable whether the *REAL* real
    > problem is that gcc is buggy/incomplete and doesn't know that kerneldoc
    > comments can be applied to structure definitions as well....
    >
    > What's the consensus? Should I go yell at the gcc people instead, or?

    Nevermind, I mistook your patch as adding a kernel doc comment.

    It's fine, I'll take it.

    Thanks!

    -- Steve

    \
     
     \ /
      Last update: 2019-03-12 16:24    [W:2.803 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site