Messages in this thread | | | Date | Tue, 12 Mar 2019 11:00:44 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] kernel/trace/trace_probe.c - make variable static |
| |
On Tue, 12 Mar 2019 04:52:58 -0400 "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
> sparse complains: > CHECK kernel/trace/trace_probe.c > kernel/trace/trace_probe.c:16:12: warning: symbol 'reserved_field_names' was not declared. Should it be static? > > Yes, it should be static.
Thanks, applied.
Note, I changed the subject to:
tracing/probes: Make reserved_field_names static
To follow the naming convention of the tracing directory.
-- Steve
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index 89da34b326e3..cfcf77e6fb19 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -13,7 +13,7 @@ > > #include "trace_probe.h" > > -const char *reserved_field_names[] = { > +static const char *reserved_field_names[] = { > "common_type", > "common_flags", > "common_preempt_count",
| |