lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/4] auxdisplay: hd44780: Fix memory leak on ->remove()
    Date
    We have to free on ->remove() the allocated resources on ->probe().

    Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support")
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/auxdisplay/hd44780.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
    index 9ad93ea42fdc..3cde351fb5c9 100644
    --- a/drivers/auxdisplay/hd44780.c
    +++ b/drivers/auxdisplay/hd44780.c
    @@ -280,6 +280,8 @@ static int hd44780_remove(struct platform_device *pdev)
    struct charlcd *lcd = platform_get_drvdata(pdev);

    charlcd_unregister(lcd);
    +
    + kfree(lcd);
    return 0;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-03-12 14:19    [W:2.754 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site