lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include
    Date
    Building with W=1 complains:
    CC [M] drivers/platform/x86/dell-rbtn.o
    drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for 'dell_rbtn_notifier_register' [-Wmissing-prototypes]
    345 | int dell_rbtn_notifier_register(struct notifier_block *nb)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/platform/x86/dell-rbtn.c:371:5: warning: no previous prototype for 'dell_rbtn_notifier_unregister' [-Wmissing-prototypes]
    371 | int dell_rbtn_notifier_unregister(struct notifier_block *nb)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    The real problem is a missing include. Add it to keep dell-rbtn.c and .h in sync

    Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

    diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
    index f3afe778001e..d50ca96d99f0 100644
    --- a/drivers/platform/x86/dell-rbtn.c
    +++ b/drivers/platform/x86/dell-rbtn.c
    @@ -17,6 +17,7 @@
    #include <linux/acpi.h>
    #include <linux/rfkill.h>
    #include <linux/input.h>
    +#include "dell-rbtn.h"

    enum rbtn_type {
    RBTN_UNKNOWN,
    \
     
     \ /
      Last update: 2019-03-12 12:26    [W:3.122 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site