Messages in this thread | | | Subject | Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev | From | "Enrico Weigelt, metux IT consult" <> | Date | Tue, 12 Mar 2019 10:33:44 +0100 |
| |
On 12.03.19 10:17, Ben Dooks wrote: > On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: >> don't need the temporary variable "dev", directly use &pdev->dev >> >> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > > This is quite usual to do, and I like it as it saves typing. > Personally I would say don't bother with this change.
hmm, both approaches have their valid arguments.
I'm not particularily biased to one or another ay, but I'd prefer having it consistent everywhere.
--mtx
-- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |