Messages in this thread - First message in thread
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- "Enrico Weigelt, metux IT consult"
- Linus Walleij
| | | Subject | Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev | From | Ben Dooks <> | Date | Tue, 12 Mar 2019 09:17:48 +0000 |
| |
On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: > don't need the temporary variable "dev", directly use &pdev->dev > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This is quite usual to do, and I like it as it saves typing. Personally I would say don't bother with this change.
> --- > drivers/gpio/gpio-janz-ttl.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c > index b97a911..91f91f6 100644 > --- a/drivers/gpio/gpio-janz-ttl.c > +++ b/drivers/gpio/gpio-janz-ttl.c > @@ -144,18 +144,17 @@ static void ttl_setup_device(struct ttl_module *mod) > static int ttl_probe(struct platform_device *pdev) > { > struct janz_platform_data *pdata; > - struct device *dev = &pdev->dev; > struct ttl_module *mod; > struct gpio_chip *gpio; > int ret; > > pdata = dev_get_platdata(&pdev->dev); > if (!pdata) { > - dev_err(dev, "no platform data\n"); > + dev_err(&pdev->dev, "no platform data\n"); > return -ENXIO; > } > > - mod = devm_kzalloc(dev, sizeof(*mod), GFP_KERNEL); > + mod = devm_kzalloc(&pdev->dev, sizeof(*mod), GFP_KERNEL); > if (!mod) > return -ENOMEM; > > @@ -181,9 +180,9 @@ static int ttl_probe(struct platform_device *pdev) > gpio->base = -1; > gpio->ngpio = 20; > > - ret = devm_gpiochip_add_data(dev, gpio, NULL); > + ret = devm_gpiochip_add_data(&pdev->dev, gpio, NULL); > if (ret) { > - dev_err(dev, "unable to add GPIO chip\n"); > + dev_err(&pdev->dev, "unable to add GPIO chip\n"); > return ret; > } > >
-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
| |