Messages in this thread | | | Date | Tue, 12 Mar 2019 10:04:30 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove() |
| |
On Tue 2019-03-12 08:58:02, Viresh Kumar wrote: > On 11-03-19, 13:05, Rafael J. Wysocki wrote: > > On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > > > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > > > and must undo the initializations done by wakeup_source_add(). Currently > > > the timer is initialized by wakeup_source_add() but removed from > > > wakeup_source_drop(), which doesn't look logically correct. Also it > > > should be okay to call wakeup_source_add() right after calling > > > wakeup_source_remove(), and in that case we may end up calling > > > timer_setup() for a potentially scheduled timer which is surely > > > incorrect. > > > > > > Move the timer removal part to wakeup_source_remove() instead.
> > > > I've merged it with the [2/2], rewritten the subject and changelog and > > queued the result as commit d856f39ac1cc ("PM / wakeup: Rework wakeup > > source timer cancellation"). > > Okay, thanks. We (Android guys) want this to be backported into 4.4+ > kernels via the stable tree. Can we mark this for stable in the commit > itself ? Else I would be required to send this separately for all the > kernels. I should have marked it for stable initially though, sorry > about forgetting then.
Greg is normally pretty agressive about backporting everything remotely looking like a fix...
But better changelog would help. How is the bug actually affecting users?
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |