lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/4] printk: Add consoles to a virtual "console" bus
Date
On Friday 03/08 at 17:34 +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 08, 2019 at 04:58:14PM +0100, Petr Mladek wrote:
> > On Fri 2019-03-08 03:56:19, John Ogness wrote:
> > > On 2019-03-02, Calvin Owens <calvinowens@fb.com> wrote:
> > > > This patch embeds a device struct in the console struct, and registers
> > > > them on a "console" bus so we can expose attributes in sysfs.
> > >
> > > I expect that "class" would be more appropriate than "bus". These
> > > devices really are grouped together based on their function and not the
> > > medium by which they are accessed.
> >
> > Good point. "class" looks better to me as well.
> >
> > Greg, any opinion, where to put the entries for struct console ?
>
> Hang them off of the device that the console belongs to?
>
> Classes and busses are almost identical except:
> - busses is the binding of a driver to a device (usb, pci, etc.)
> - classes are usually userspace interactions to a device (input,
> tty, etc.)
>
> So this sounds like a class to me.

Sounds good, will make it a class.

> If you want me to review this, I'll be glad to so do once 5.1-rc1 is
> out...

Yeah, I realized after sending this the timing was pretty terrible, I'll
wait for 5.1-rc1 before rebasing/resending.

Thanks,
Calvin

> thanks,
>
> greg k-h
\
 
 \ /
  Last update: 2019-03-12 21:45    [W:0.050 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site