Messages in this thread Patch in this message | | | From | "Valdis Klētnieks" <> | Subject | [PATCH] b/arch/x86/mm/pti.c - make local symbols static | Date | Tue, 12 Mar 2019 03:47:53 -0400 |
| |
With 'make C=2 W=1', sparse and gcc both complain:
CHECK arch/x86/mm/pti.c arch/x86/mm/pti.c:84:3: warning: symbol 'pti_mode' was not declared. Should it be static? arch/x86/mm/pti.c:605:6: warning: symbol 'pti_set_kernel_image_nonglobal' was not declared. Should it be static? CC arch/x86/mm/pti.o arch/x86/mm/pti.c:605:6: warning: no previous prototype for 'pti_set_kernel_image_nonglobal' [-Wmissing-prototypes] 605 | void pti_set_kernel_image_nonglobal(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And indeed, the function at line 605 is only used locally. 'pti_mode' is more subtle - there is another pti_mode in drivers/hwtracing/intel_th/pti.c, but it's an array declared static, not an enum
Make both variables static.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index 4fee5c3003ed..139b28a01ce4 100644 --- a/arch/x86/mm/pti.c +++ b/arch/x86/mm/pti.c @@ -77,7 +77,7 @@ static void __init pti_print_if_secure(const char *reason) pr_info("%s\n", reason); } -enum pti_mode { +static enum pti_mode { PTI_AUTO = 0, PTI_FORCE_OFF, PTI_FORCE_ON @@ -602,7 +602,7 @@ static void pti_clone_kernel_text(void) set_memory_global(start, (end_global - start) >> PAGE_SHIFT); } -void pti_set_kernel_image_nonglobal(void) +static void pti_set_kernel_image_nonglobal(void) { /* * The identity map is created with PMDs, regardless of the
| |