Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 12 Mar 2019 20:01:18 +0100 | Subject | Re: [PATCH 27/42] drivers: gpio: rcar: use devm_platform_ioremap_resource() |
| |
CC linux-renesas-soc
On Mon, Mar 11, 2019 at 7:58 PM Enrico Weigelt, metux IT consult <info@metux.net> wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -430,7 +430,7 @@ static int gpio_rcar_parse_dt(struct gpio_rcar_priv *p, unsigned int *npins) > static int gpio_rcar_probe(struct platform_device *pdev) > { > struct gpio_rcar_priv *p; > - struct resource *io, *irq; > + struct resource *irq; > struct gpio_chip *gpio_chip; > struct irq_chip *irq_chip; > struct device *dev = &pdev->dev; > @@ -461,8 +461,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) > goto err0; > } > > - io = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - p->base = devm_ioremap_resource(dev, io); > + p->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(p->base)) { > ret = PTR_ERR(p->base); > goto err0;
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |