lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings
On Mon, Mar 04, 2019 at 09:20:05PM +0100, Lubomir Rintel wrote:
> There's a generic compatible string and the driver will work on a MMP2 as
> well, using the same binding.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Added marvell,armada-lcdc compatible string.
>
> .../devicetree/bindings/display/marvell,armada-lcdc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> index 2606a8efc956..4ef66bc2845c 100644
> --- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> +++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> @@ -3,7 +3,9 @@ Marvell Armada LCD controller
>
> Required properties:
>
> - - compatible: value should be "marvell,dove-lcd".
> + - compatible: value should be "marvell,armada-lcdc" along with
> + "marvell,dove-lcd" or "marvell,mmp2-lcd", depending on the
> + exact SoC model.

It is not exactly clear what the order is here. The preferred form is:

compatible: must be one of:
a
b
c
followed by 'fallback'

So "marvell,armada-lcdc" is the fallback, but you can't start requiring
the existing "marvell,dove-lcd" to have a fallback. At least you can't
depend on that.

> - reg: base address and size of the LCD controller
> - interrupts: single interrupt number for the LCD controller
>
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2019-03-12 19:43    [W:0.041 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site