lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 07/10] drm/arm/malidp:- Writeback framebuffer does not support any modifiers
    Date
    From: Ayan Kumar Halder <ayan.halder@arm.com>

    In malidp, the writeback pipeline does not support writing crtc output
    to a framebuffer with modifiers ie the memory writeback content is
    devoid of any compression or tiling, etc.
    So we have added a commit check in memory writeback encoder helper function
    to validate if the framebuffer has any modifier and if so, return EINVAL.

    Changes since v3 (series):
    - Added the ack
    - Rebased on the latest drm-misc-next

    Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
    Acked-by: Liviu Dudau <liviu.dudau@arm.com>
    Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
    ---
    drivers/gpu/drm/arm/malidp_mw.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
    index 28cd351..2865f7a 100644
    --- a/drivers/gpu/drm/arm/malidp_mw.c
    +++ b/drivers/gpu/drm/arm/malidp_mw.c
    @@ -141,6 +141,11 @@ malidp_mw_encoder_atomic_check(struct drm_encoder *encoder,
    return -EINVAL;
    }

    + if (fb->modifier) {
    + DRM_DEBUG_KMS("Writeback framebuffer does not support modifiers\n");
    + return -EINVAL;
    + }
    +
    mw_state->format =
    malidp_hw_get_format_id(&malidp->dev->hw->map, SE_MEMWRITE,
    fb->format->format, !!fb->modifier);
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-03-12 19:17    [W:3.214 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site