lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 077/171] ARM: dts: meson8m2: mxiii-plus: mark the SD card detection GPIO active-low
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 8615f5596335db0978cea593dcd0070dc5f8b116 ]

    After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device
    tree") SD cards are not detected anymore.

    The CD GPIO is "active low" on the MXIII-Plus. The MMC dt-bindings
    specify: "[...] using the "cd-inverted" property means, that the CD line
    is active high, i.e. it is high, when a card is inserted".

    Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and
    drop the "cd-inverted" property. This makes the definition consistent
    with the existing dt-bindings and fixes the check whether an SD card is
    inserted.

    Fixes: 35ee52bea66c74 ("ARM: dts: meson8m2: add support for the Tronsmart MXIII Plus")
    Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Kevin Hilman <khilman@baylibre.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    index f5853610b20b..6ac02beb5fa7 100644
    --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    @@ -206,8 +206,7 @@
    cap-sd-highspeed;
    disable-wp;

    - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
    - cd-inverted;
    + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;

    vmmc-supply = <&vcc_3v3>;
    };
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-03-12 19:04    [W:4.107 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site