lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 005/135] staging: comedi: ni_660x: fix missing break in switch statement
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit 479826cc86118e0d87e5cefb3df5b748e0480924 upstream.

    Add missing break statement in order to prevent the code from falling
    through to the default case and return -EINVAL every time.

    This bug was found thanks to the ongoing efforts to enable
    -Wimplicit-fallthrough.

    Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
    Cc: stable@vger.kernel.org
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/comedi/drivers/ni_660x.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/staging/comedi/drivers/ni_660x.c
    +++ b/drivers/staging/comedi/drivers/ni_660x.c
    @@ -611,6 +611,7 @@ static int ni_660x_set_pfi_routing(struc
    case NI_660X_PFI_OUTPUT_DIO:
    if (chan > 31)
    return -EINVAL;
    + break;
    default:
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2019-03-12 18:45    [W:4.171 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site