Messages in this thread Patch in this message | | | Date | Mon, 11 Mar 2019 20:44:31 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/8] aio: store event at final iocb_put() |
| |
On Sun, Mar 10, 2019 at 07:08:17AM +0000, Al Viro wrote: > From: Al Viro <viro@zeniv.linux.org.uk> > > Instead of having aio_complete() set ->ki_res.{res,res2}, do that > explicitly in its callers, drop the reference (as aio_complete() > used to do) and delay the rest until the final iocb_put(). > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > --- > fs/aio.c | 45 ++++++++++++++++++++------------------------- > 1 file changed, 20 insertions(+), 25 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 2249a7a1d6b3..b9c4c1894020 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1077,24 +1077,10 @@ static inline void iocb_destroy(struct aio_kiocb *iocb) > kmem_cache_free(kiocb_cachep, iocb); > } > > -static inline void iocb_put(struct aio_kiocb *iocb) > -{ > - if (refcount_dec_and_test(&iocb->ki_refcnt)) > - iocb_destroy(iocb); > -}
Maybe iocb_put should just have been added in the place you move it to in patch 1?
| |