Messages in this thread | | | Subject | Re: [PATCH v2] net: renesas: fix a missing check of of_get_phy_mode | From | Sergei Shtylyov <> | Date | Mon, 11 Mar 2019 20:55:30 +0300 |
| |
On 03/11/2019 08:52 PM, David Miller wrote:
>>> of_get_phy_mode may fail and return a negative error code; >>> the fix checks the return value of of_get_phy_mode and >>> returns NULL of it fails. >> >> Sorry, I overlooked this issue. >> >>> Signed-off-by: Kangjie Lu <kjlu@umn.edu> >> >> Fixes: b356e978e92f ("sh_eth: add device tree support") >> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >>> --- >>> drivers/net/ethernet/renesas/sh_eth.c | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Why are you not fixing ravb_main.c as well? Especially as you have "renesas:" >> in your subject, not "sh_eth:"? :-/ > > Kangjie please fix the subject line and incorporate Sergei's Fixes and > Reviewed-by tags.
For the record, this patch was a nop, I have to NAK it. Kangjie, please address Geert's feedback, thanks.
> Thanks.
MBR, Sergei
| |