Messages in this thread Patch in this message | | | From | Kangjie Lu <> | Subject | [PATCH] net: renesas: fix a potential NULL pointer dereference | Date | Mon, 11 Mar 2019 02:01:36 -0500 |
| |
In case of_get_phy_mode fails, the fix returns NULL to avoid the NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/net/ethernet/renesas/sh_eth.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 339b2eae2100..b119587ec673 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3187,6 +3187,8 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev) return NULL; pdata->phy_interface = of_get_phy_mode(np); + if (unlikely(!pdata->phy_interface)) + return NULL; mac_addr = of_get_mac_address(np); if (mac_addr) -- 2.17.1
| |