lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 11/15] perf tools report: Implement browsing of individual samples
On Fri, Mar 08, 2019 at 09:56:24PM -0800, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 08e2b3be4c1b..da3a944f42aa 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -445,6 +445,14 @@ static int hist_entry__init(struct hist_entry *he,
> return -ENOMEM;
> }
> }
> +
> + if (symbol_conf.res_sample) {
> + he->res_samples = calloc(sizeof(struct res_sample),
> + symbol_conf.res_sample);
> + if (!he->res_samples)

you need to free the memory in here, anyway this function
just changed, so please rebase on latest Arnaldo's perf/core

jirka

> + return -ENOMEM;
> + }
> +

SNIP

\
 
 \ /
  Last update: 2019-03-11 13:32    [W:0.086 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site