lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 5.0-rc1 Open circuit voltage tables -- 3afb50d7125bc
On Mon 2019-01-07 20:05:55, Pavel Machek wrote:
> Hi!
>
> Can we do something with that code?
>
> First -- tables should not be necceessary. Formula for li-ion open
> circuit voltage is well-known, and does not really depend on the
> device -- only on the chemistry of battery.
>
> state of charge = f( voltage, current, internal resistance )
>
> (And yes, internal resistance depends on temperature and health of the
> battery).
>
> Second, even if we need tables, why is it doing multiple allocations?
>
> info->ocv_temp[index] = -EINVAL;
>
> That's just wrong. Ocv_temp is temperature in celsius. Temperatures go
> below zero.

Ping? That code is just bad. Does someone care?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-11 11:25    [W:0.040 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site