Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support | From | Neil Armstrong <> | Date | Mon, 11 Mar 2019 09:53:08 +0100 |
| |
On 08/03/2019 15:54, Rob Herring wrote: > On Fri, Mar 8, 2019 at 2:05 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> Hi Rob, >> >> On 08/03/2019 00:13, Rob Herring wrote: >>> On Fri, Feb 1, 2019 at 6:08 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >>>> >>>> Add support for SCDC Setup for TMDS Clock > 3.4GHz and enable TMDS >>>> Scrambling when supported or mandatory. >>>> >>>> This patch also adds an helper to setup the control bit to support >>>> the high TMDS Bit Period/TMDS Clock-Period Ratio as required with >>>> TMDS Clock > 3.4GHz for HDMI2.0 3840x2160@60/50 modes. >>>> >>>> These changes were based on work done by Huicong Xu <xhc@rock-chips.com> >>>> and Nickey Yang <nickey.yang@rock-chips.com> to support HDMI2.0 modes >>>> on the Rockchip 4.4 BSP kernel at [1] >>>> >>>> [1] https://github.com/rockchip-linux/kernel/tree/release-4.4 >>>> >>>> Cc: Nickey Yang <nickey.yang@rock-chips.com> >>>> Cc: Huicong Xu <xhc@rock-chips.com> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >>>> Tested-by: Heiko Stuebner <heiko@sntech.de> >>>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> >>>> --- >>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 85 ++++++++++++++++++++++++++++++- >>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 + >>>> include/drm/bridge/dw_hdmi.h | 1 + >>>> 3 files changed, 85 insertions(+), 2 deletions(-) >>> >>> This commit in drm-misc-next is breaking booting on the Rock960. I >>> have FB and fbcon enabled. The boot hangs after this message: >>> >>> [ 3.012334] [drm:rockchip_drm_fbdev_create] FB [1920x1080]-24 >>> kvaddr=(____ptrval____) offset=0 size=8294400 >> >> Could you give more details on the tree used ? did you bisect to find this commit ? > > As I said above, drm-misc-next (from drm-misc tree) is the branch. I > bisected between it and v5.0. Reverting it fixes booting.
Thanks, could you give more details on the environment ? Did you test over the latest linux-next ?
Can you share the EDID of your monitor ?
Can you check this patch :
----><---------------------------------------------------------------------------------------- diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index a63e5f0dae56..f33c2ac158c1 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1268,8 +1268,6 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi)
dw_hdmi_phy_power_off(hdmi);
- dw_hdmi_set_high_tmds_clock_ratio(hdmi); - /* Leave low power consumption mode by asserting SVSRET. */ if (phy->has_svsret) dw_hdmi_phy_enable_svsret(hdmi, 1);
| |