lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > + if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > + goto log_it;
> > +
>
> Can you please include a vendor check with this? MCi_STATUS[56] is
> not defined the same way on AMD systems.

Original code also looked at MCi_STATUS[56] without a vendor
check:

> > - (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))

Was this OK because you don't set mca_cfg.ser?

If so, my new code will also skip out before getting to this test. But
should probably have a better comment. Something like:


/*
* Newer Intel systems that support software error
* recovery need to make some extra checks. Other
* CPUs should skip over uncorrected errors, but log
* everything else
*/
if (!mca_cfg.ser) {
if (m.status & MCI_STATUS_UC)
continue;
goto log_it;
}

-Tony

\
 
 \ /
  Last update: 2019-03-11 21:43    [W:0.071 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site