lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: fujitsu: fix a potential NULL pointer dereference
From
From: Kangjie Lu <kjlu@umn.edu>
Date: Mon, 11 Mar 2019 01:15:01 -0500

> In case ioremap fails, the fix returns -ENOMEM to avoid the
> NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/ethernet/fujitsu/fmvj18x_cs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/fujitsu/fmvj18x_cs.c b/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
> index a69cd19a55ae..5061ddf699a7 100644
> --- a/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
> +++ b/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
> @@ -547,6 +547,9 @@ static int fmvj18x_get_hwinfo(struct pcmcia_device *link, u_char *node_id)
> return -1;
>
> base = ioremap(link->resource[2]->start, resource_size(link->resource[2]));
> + if (!base)
> + return -ENOMEM;
> +

You must release the pcmcia window if you exit the function here.

\
 
 \ /
  Last update: 2019-03-11 21:37    [W:0.049 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site