Messages in this thread Patch in this message | | | From | Sven Van Asbroeck <> | Subject | [PATCH v2] PCIE/PME: fix possible use-after-free on remove | Date | Fri, 1 Mar 2019 11:54:19 -0500 |
| |
In remove(), ensure that the pme work cannot run after kfree() is called. Otherwise, this could result in a use-after-free.
This issue was detected with the help of Coccinelle.
Cc: Sinan Kaya <okaya@kernel.org> Cc: Frederick Lawler <fred@fredlawl.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Keith Busch <keith.busch@intel.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> --- drivers/pci/pcie/pme.c | 1 + 1 file changed, 1 insertion(+)
v2: rebased against Bjorn Helgaas's pcm/pm branch at git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index efa5b552914b..54d593d10396 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv) pcie_pme_disable_interrupt(srv->port, data); free_irq(srv->irq, srv); + cancel_work_sync(&data->work); kfree(data); } -- 2.17.1
| |