lkml.org 
[lkml]   [2019]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure'
Date

Le 01/03/2019 à 16:26, James Bottomley a écrit :
> [...]
> Shouldn't this be a variant of sdev/scmd_printk? Otherwise it tells
> you what disk in the array terms is the problem but not what device in
> your actual system is affected.

Hey James,

My initial take on that was that pqi_take_device_offline(), which is
called just after, will print the "re-scanning " message with the same
format.

As they will be both printed in the same error context and one after the
other, I though that would make sense to represent the same information
to ease the reading like cause -> consequence.

As the message is about the LUN itself, which is reported faulty, I
though it would worth reporting the info that way.

Shall I consider printing also the disk name in addition ?

Erwan,


\
 
 \ /
  Last update: 2019-03-01 16:44    [W:0.092 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site