lkml.org 
[lkml]   [2019]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Coding style fixes on vme_user.c trivial
On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote:
> drivers/staging/devices: Coding style fixes found at file vme_user.c.


Your subject line, and this changelog text, need a lot of work. Please
look at the other patches that have been accepted for this driver as
examples of how to do this properly.

>
> Signed-off-by: Oryan Perlmutter <oryan.perl1997@gmail.com>
> ---
> drivers/staging/vme/devices/vme_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 6a33aaa1a49f..4c7db4f5f15e 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev)
> int cur_slot = vme_slot_num(vdev);
>
> for (i = 0; i < bus_num; i++)
> - if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
> + if (cur_bus == bus[i] && cur_slot == vdev->num)

Personally, I like the original code here, it's more explicit as to what
is going on.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-03-01 16:18    [W:0.044 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site