lkml.org 
[lkml]   [2019]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/20] x86/io: Remove useless definition of mmiowb()
    Date
    x86 maps mmiowb() to barrier(), but this is superfluous because a
    compiler barrier is already implied by spin_unlock(). Since x86 also
    includes asm-generic/io.h in its asm/io.h file, we can remove the
    definition entirely and pick up the dummy definition from core code.

    Signed-off-by: Will Deacon <will.deacon@arm.com>
    ---
    arch/x86/include/asm/io.h | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
    index 686247db3106..a06a9f8294ea 100644
    --- a/arch/x86/include/asm/io.h
    +++ b/arch/x86/include/asm/io.h
    @@ -90,8 +90,6 @@ build_mmio_write(__writel, "l", unsigned int, "r", )
    #define __raw_writew __writew
    #define __raw_writel __writel

    -#define mmiowb() barrier()
    -
    #ifdef CONFIG_X86_64

    build_mmio_read(readq, "q", u64, "=r", :"memory")
    --
    2.11.0
    \
     
     \ /
      Last update: 2019-03-01 15:05    [W:5.914 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site