Messages in this thread | | | Subject | Re: [PATCH] printk: Remove no longer used LOG_PREFIX. | From | Tetsuo Handa <> | Date | Fri, 1 Mar 2019 19:31:59 +0900 |
| |
Can this patch go to Linux 5.1?
On 2019/02/22 18:59, Tetsuo Handa wrote: > When commit 5becfb1df5ac8e49 ("kmsg: merge continuation records while > printing") introduced LOG_PREFIX, we used KERN_DEFAULT etc. as a flag > for setting LOG_PREFIX in order to tell whether to call cont_add() > (i.e. whether to append the message to "struct cont"). > > But since commit 4bcc595ccd80decb ("printk: reinstate KERN_CONT for > printing continuation lines") inverted the behavior (i.e. don't append > the message to "struct cont" unless KERN_CONT is specified) and commit > 5aa068ea4082b39e ("printk: remove games with previous record flags") > removed the last LOG_PREFIX check, setting LOG_PREFIX via KERN_DEFAULT > etc. is no longer meaningful. > > Therefore, we can remove LOG_PREFIX and make KERN_DEFAULT empty string. > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > --- > include/linux/kern_levels.h | 2 +- > include/linux/printk.h | 1 - > kernel/printk/printk.c | 6 +----- > 3 files changed, 2 insertions(+), 7 deletions(-)
| |