Messages in this thread | | | Date | Sat, 9 Feb 2019 19:24:18 +0100 | From | Jiri Pirko <> | Subject | Re: [PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET |
| |
Sat, Feb 09, 2019 at 07:21:47PM CET, jiri@resnulli.us wrote:
[...]
>>+static int >>+rocker_switchdev_port_attr_event(unsigned long event, struct net_device *netdev, >>+ struct switchdev_notifier_port_attr_info >>+ *port_attr_info) >>+{ >>+ int err = -EOPNOTSUPP; >>+ >>+ switch (event) { >>+ case SWITCHDEV_PORT_ATTR_SET: > >Do you expect some other event to be handled in >rocker_switchdev_port_attr_event()? Because you have SWITCHDEV_PORT_ATTR_SET >selected in case here and in rocker_switchdev_blocking_event. >Perhaps you can rename rocker_switchdev_port_attr_event() to >rocker_switchdev_port_attr_set_event() and avoid this switchcase.
Same comment applies on next 4 patches.
| |