Messages in this thread | | | Date | Fri, 8 Feb 2019 09:01:42 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE |
| |
On Thu, Feb 07, 2019 at 09:45:49AM +0200, Eli Cohen wrote: > Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For > example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with > TCA_ID_POLICE and also differentiates these identifier, used in struct > tc_action_ops type field, from other macros starting with TCA_ACT_. > > To make things clearer, we name the enum defining the TCA_ID_* > identifiers and also change the "type" field of struct tc_action to > id. > > Signed-off-by: Eli Cohen <eli@mellanox.com> > Acked-by: Jiri Pirko <jiri@mellanox.com>
...
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h > index 7ab55f97e7c4..51a0496f78ea 100644 > --- a/include/uapi/linux/pkt_cls.h > +++ b/include/uapi/linux/pkt_cls.h > @@ -85,7 +85,7 @@ enum { > #define TCA_ACT_SAMPLE 26 > > /* Action type identifiers*/ > -enum { > +enum tca_id { > TCA_ID_UNSPEC = 0, > TCA_ID_POLICE = 1, > TCA_ID_GACT = TCA_ACT_GACT,
This change updates the UAPI. It seems to me that it would not break existing users. But I would like to ask if this has been given due consideration.
...
| |