Messages in this thread | | | Date | Fri, 08 Feb 2019 16:51:53 +0100 | From | Danilo Krummrich <> | Subject | Re: [PATCH] Input: ps2-gpio - flush TX work when closing port |
| |
On 2019-02-08 08:31, Dmitry Torokhov wrote: > On Thu, Feb 07, 2019 at 06:03:03PM -0500, Sven Van Asbroeck wrote: >> On Thu, Feb 7, 2019 at 5:27 PM Dmitry Torokhov >> <dmitry.torokhov@gmail.com> wrote: >> > >> > + flush_work(&drvdata->tx_work.work); >> >> Would cancel_work_sync() be better than flush_work() ? > > No, because we want to have interrupt and gpios in a consistent state. > If we cancel then we need to see if we should disable it or it may > already be disabled, etc. This way we know it is enabled after > flush_delayed_work() returns, and we need to disable it. > > Thanks.
I agree with Dmitry - thanks for the fix.
Acked-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
| |