Messages in this thread | | | Date | Fri, 8 Feb 2019 12:13:35 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/6] vmw_balloon: support 64-bit memory limit |
| |
On Wed, Feb 06, 2019 at 03:57:02PM -0800, Nadav Amit wrote: > From: Xavier Deguillard <xdeguillard@vmware.com> > > Currently, the balloon driver would fail to run if memory is greater > than 16TB of vRAM. Previous patches have already converted the balloon > target and size to 64-bit, so all that is left to do add is to avoid > asserting memory is smaller than 16TB if the hypervisor supports 64-bits > target. > > The driver advertises a new capability VMW_BALLOON_64_BITS_TARGET. > Hypervisors that support 16TB of memory or more will report that this > capability is enabled. > > Signed-off-by: Xavier Deguillard <xdeguillard@vmware.com> > Signed-off-by: Nadav Amit <namit@vmware.com> > --- > drivers/misc/vmw_balloon.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index c4371ec132d3..f96dc3690ade 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -72,15 +72,26 @@ enum vmwballoon_capabilities { > VMW_BALLOON_BATCHED_CMDS = (1 << 2), > VMW_BALLOON_BATCHED_2M_CMDS = (1 << 3), > VMW_BALLOON_SIGNALLED_WAKEUP_CMD = (1 << 4), > + VMW_BALLOON_64_BIT_TARGET = (1 << 5)
Nit, this should be BIT(5), right?
You can change that in a later patch...
thanks,
greg k-h
| |