Messages in this thread | | | Subject | Re: [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt | From | Florian Fainelli <> | Date | Thu, 7 Feb 2019 16:07:47 -0800 |
| |
On 2/7/19 4:01 PM, Arun Parameswaran wrote: > Fixes the issues with non BCM58XX chips in the b53 driver > failing, when the irq is not specified in the device tree. > > Removed the check for BCM58XX in b53_srab_prepare_irq(), > so the 'port->irq' will be set to '-EXIO' if the irq is not > specified in the device tree. > > Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts") > Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized") > Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Arun!
> --- > drivers/net/dsa/b53/b53_srab.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c > index 90f514252987..d9c56a779c08 100644 > --- a/drivers/net/dsa/b53/b53_srab.c > +++ b/drivers/net/dsa/b53/b53_srab.c > @@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct platform_device *pdev) > /* Clear all pending interrupts */ > writel(0xffffffff, priv->regs + B53_SRAB_INTR); > > - if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID) > - return; > - > for (i = 0; i < B53_N_PORTS; i++) { > port = &priv->port_intrs[i]; > >
-- Florian
| |