| From | Paul Burton <> | Subject | Re: [PATCH 01/18] MIPS: lantiq: pass struct device to DMA API functions | Date | Thu, 7 Feb 2019 23:29:14 +0000 |
| |
Hi Christoph,
On Fri, Feb 01, 2019 at 09:47:44AM +0100, Christoph Hellwig wrote: > The DMA API generally relies on a struct device to work properly, and > only barely works without one for legacy reasons. Pass the easily > available struct device from the platform_device to remedy this. > > Also use GFP_KERNEL instead of GFP_ATOMIC as the gfp_t for the memory > allocation, as we aren't in interrupt context or under a lock. > > Note that this whole function looks somewhat bogus given that we never > even look at the returned dma address, and the CPHYSADDR magic on > a returned noncached mapping looks "interesting". But I'll leave > that to people more familiar with the code to sort out. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > arch/mips/lantiq/xway/vmmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Would you like this to go through the MIPS tree or elsewhere? If the latter:
Acked-by: Paul Burton <paul.burton@mips.com>
Thanks, Paul
|