Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH] drm/vc4: Use struct_size() in kzalloc() | Date | Thu, 07 Feb 2019 14:59:02 -0800 |
| |
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed and pushed to drm-misc-next. Thanks! [unhandled content-type:application/pgp-signature] | |