Messages in this thread | | | Subject | Re: [PATCH] arch: riscv: fix logic error in parse_dtb | From | Atish Patra <> | Date | Thu, 7 Feb 2019 14:47:20 -0800 |
| |
On 2/7/19 6:44 AM, Andreas Schwab wrote: > The function early_init_dt_scan returns true if a DTB was detected. > > Fixes: 8fd6e05c7463 ("arch: riscv: support kernel command line forcing when no DTB passed") > Signed-off-by: Andreas Schwab <schwab@suse.de> > --- > arch/riscv/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index 45e9a2f053dc..84f19ca6d88b 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -140,7 +140,7 @@ asmlinkage void __init setup_vm(void) > > void __init parse_dtb(unsigned int hartid, void *dtb) > { > - if (!early_init_dt_scan(__va(dtb))) > + if (early_init_dt_scan(__va(dtb))) > return; > > pr_err("No DTB passed to the kernel\n"); >
Good catch. I was surprised to see "No DTB passed.." message with rc5.
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Regards, Atish
| |